fix(underused): Do not check overused when there is no UnderUsedResourceFn added #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/XS
eggiter
force-pushed
the
fix-underused
branch
from
19c57a1
to
e32ec1a
Compare
|
/assign @Thor-wl |
eggiter
changed the title
Thor-wl
requested review from
shinytang6,
wpeng102 and
jasonliu747
and removed request for
alcorj-mizar
|
Thanks for the fix. |
volcano-sh-bot
added
the
approved
|
/hold |
volcano-sh-bot
added
the
do-not-merge/hold
k82cn
reviewed
Sep 7, 2021
| @@ -205,7 +205,7 @@ func (alloc *Action) Execute(ssn *framework.Session) { | |||
| // Check whether the queue is overused on dimension that the task requested | |||
| taskRequest := task.Resreq.ResourceNames() | |||
|
|
|||
| if !ssn.UnderusedResources(queue).Contains(taskRequest) { | |||
| if ssn.UnderusedResourceRegistered() && !ssn.UnderusedResources(queue).Contains(taskRequest) { | |||
There was a problem hiding this comment.
return nil if no fn registered, return [] if no under-used resources.
eggiter
force-pushed
the
fix-underused
branch
from
e32ec1a
to
8cef261
Compare
volcano-sh-bot
added
size/S
eggiter
changed the title
eggiter
force-pushed
the
fix-underused
branch
from
4c5a6c2
to
8d7ecb0
Compare
…rceFn added Signed-off-by: eggiter <haodonglyu@gmail.com>
eggiter
force-pushed
the
fix-underused
branch
from
8d7ecb0
to
8aafa2e
Compare
|
/hold cancel /lgtm |
volcano-sh-bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnderUsedResourceFnadded.