Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vcjob not work when mount volume #1742

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

Thor-wl
Copy link
Member

@Thor-wl Thor-wl commented Sep 13, 2021

fix: #1609
Signed-off-by: Thor-wl 13164644535@163.com

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2021
@Thor-wl Thor-wl requested review from hwdef, jasonliu747, william-wang and shinytang6 and removed request for hzxuzhonghu and k82cn September 13, 2021 03:53
Signed-off-by: Thor-wl <13164644535@163.com>
@hwdef
Copy link
Member

hwdef commented Sep 13, 2021

Why do we need to update pvc, please explain the reason.

@Thor-wl
Copy link
Member Author

Thor-wl commented Sep 13, 2021

Why do we need to update pvc, please explain the reason.

PVC not existing will be created automatically by volcano such as the pvSpec specified in e2e "use exisisting PVC in job". That's the root reason why that case cannot pass ever.

Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2021
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@volcano-sh-bot volcano-sh-bot merged commit ded9832 into volcano-sh:master Sep 13, 2021
@hwdef
Copy link
Member

hwdef commented Sep 13, 2021

But when vcjob is bound to an existing pvc, there will be this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There may be something wrong with "pod affinity" and "pod with volume"
4 participants