Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch the order of patch and existence check #1852

Merged
merged 1 commit into from
Nov 25, 2021
Merged

switch the order of patch and existence check #1852

merged 1 commit into from
Nov 25, 2021

Conversation

zzr93
Copy link

@zzr93 zzr93 commented Nov 24, 2021

  1. The existence check of GPU device id seems unnecessary since id was just generated using the same struct, but we can save it as a double check.
  2. However, current order of patch and existence check can lead to a situation where the patch succeed but the check failed. In this case, a pod in PodMap will be missed.

@volcano-sh-bot
Copy link
Contributor

Welcome @zzr88!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 24, 2021
@zzr93
Copy link
Author

zzr93 commented Nov 24, 2021

/assign @Thor-wl

switch the order of patch and existence check
c9206fe 
Signed-off-by: zhouzhirui <zhouzhirui@jd.com>
@Thor-wl
Copy link
Member

Thor-wl commented Nov 24, 2021

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2021
@Thor-wl
Copy link
Member

Thor-wl commented Nov 25, 2021

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2021
@volcano-sh-bot volcano-sh-bot merged commit 3f47e26 into volcano-sh:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

@zen-xu zen-xu Awaiting requested review from zen-xu

Assignees

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zzr93 @volcano-sh-bot @Thor-wl