Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JobReady for extender plugin #2334

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

xiaoxubeii
Copy link
Contributor

@xiaoxubeii xiaoxubeii commented Jul 6, 2022

#2335
Add JobReady verb for extender plugin to support extender scheduler do something like pod updates after node predicates.

@volcano-sh-bot
Copy link
Contributor

Welcome @xiaoxubeii!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 6, 2022
Signed-off-by: xiaoxubeii <xiaoxubeii@gmail.com>
@Thor-wl
Copy link
Member

Thor-wl commented Jul 6, 2022

@xiaoxubeii Hi, thanks for your contribution! Can you submit an issue and add some descriptions about this PR?

@xiaoxubeii
Copy link
Contributor Author

xiaoxubeii commented Jul 6, 2022

@xiaoxubeii Hi, thanks for your contribution! Can you submit an issue and add some descriptions about this PR?

@Thor-wl Have added issue and updated the pr description. #2334

@Thor-wl Thor-wl requested review from Thor-wl, hwdef and shinytang6 and removed request for k82cn and zen-xu July 6, 2022 12:38
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2022
@Thor-wl
Copy link
Member

Thor-wl commented Jul 7, 2022

/lgtm

@volcano-sh-bot volcano-sh-bot merged commit 345c98e into volcano-sh:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants