Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick for release-1.8]support preemption when the number of attachment volumes of a node reaches the upper limit #3212

Merged
merged 2 commits into from
Nov 22, 2023
Merged

[cherry-pick for release-1.8]support preemption when the number of attachment volumes of a node reaches the upper limit #3212

merged 2 commits into from
Nov 22, 2023

Conversation

Lily922
Copy link
Contributor

@Lily922 Lily922 commented Nov 20, 2023 •
edited

cherry-pick pr: #3211

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 20, 2023
@Lily922 Lily922 changed the title support preemption when the number of pods of a node reaches the upper limit [cherry-pick for release-1.8]support preemption when the number of pods of a node reaches the upper limit Nov 20, 2023
@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 20, 2023
@Lily922 Lily922 changed the title [cherry-pick for release-1.8]support preemption when the number of pods of a node reaches the upper limit [cherry-pick for release-1.8]support preemption when the number of attachment volumes of a node reaches the upper limit Nov 20, 2023
@Lily922 Lily922 force-pushed the volumelimit-1.8 branch 4 times, most recently from 40ae3df to d11906e Compare November 20, 2023 13:54
@Lily922
support preemption when the number of attachment volumes of a node re…
b6e1a42 
…aches the upper limit

Signed-off-by: lili <lili_9309@163.com>
@Lily922
update UT tests
d15a234 
Signed-off-by: lili <lili_9309@163.com>
@wangyang0616
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
william-wang
william-wang approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@volcano-sh-bot volcano-sh-bot merged commit 43e368b into volcano-sh:release-1.8 Nov 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-wang william-wang william-wang approved these changes

@alcorj-mizar alcorj-mizar Awaiting requested review from alcorj-mizar

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@william-wang william-wang

@wangyang0616 wangyang0616

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lily922 @wangyang0616 @volcano-sh-bot @william-wang