Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Verify Job to check consistency between generate yaml and the yam… #373

Merged
merged 2 commits into from
Jul 23, 2019

Conversation

asifdxtreme
Copy link
Contributor

…l in the repo

#347

@asifdxtreme asifdxtreme requested review from TommyLike and hzxuzhonghu and removed request for hex108, kevin-wangzefeng and TommyLike July 22, 2019 11:23
@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2019
@TommyLike
Copy link
Contributor

/lgtm @hzxuzhonghu please take a look

@TommyLike
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@k82cn
Copy link
Member

k82cn commented Jul 23, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asifdxtreme, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@volcano-sh-bot volcano-sh-bot merged commit f9f1724 into volcano-sh:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants