Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRD Definition #433

Merged
merged 3 commits into from
Sep 5, 2019
Merged

Fix CRD Definition #433

merged 3 commits into from
Sep 5, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

fixes: #432

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 4, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ec24fe90-cf0e-11e9-b497-efc33f11dce4

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8302ab00-cf0f-11e9-b497-efc33f11dce4

@hzxuzhonghu
Copy link
Collaborator Author

/assign @TommyLike

@TommyLike
Copy link
Contributor

Need to fix the CI issue first.

@TommyLike
Copy link
Contributor

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@k82cn
Copy link
Member

k82cn commented Sep 5, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@volcano-sh-bot volcano-sh-bot merged commit d378824 into volcano-sh:master Sep 5, 2019
@hzxuzhonghu hzxuzhonghu deleted the crd branch September 6, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Install volcano failed on kubernetes master
5 participants