Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VC_TASK_INDEX and added env to initContainers. #613

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Dec 16, 2019

Signed-off-by: Klaus Ma klaus1982.cn@gmail.com

fixed #453

Deprecated VK_TASK_INDEX, and enable VC_TASK_INDEX; also add env vars into initContainers.

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2019
@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2019
@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 7638d220-1fad-11ea-ba47-7f442aed9c1e

Signed-off-by: Klaus Ma <klaus1982.cn@gmail.com>
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2019
@volcano-sh-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2019
@TravisBuddy
Copy link

Hey @k82cn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 65f57600-1fd2-11ea-ba47-7f442aed9c1e

@volcano-sh-bot volcano-sh-bot merged commit 2f688bd into volcano-sh:master Dec 16, 2019
@k82cn k82cn deleted the vc_453 branch December 25, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we make env plugin work in the initContainers?
4 participants