Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update factory.go #614

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Update factory.go #614

merged 2 commits into from
Dec 16, 2019

Conversation

YesterdayxD
Copy link
Contributor

replace parameter type

@YesterdayxD
Update factory.go
c15b8d2 
replace parameter type
@volcano-sh-bot
Copy link
Contributor

Welcome @YesterdayxD!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 16, 2019
@hzxuzhonghu
Copy link
Collaborator

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, YesterdayxD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
hzxuzhonghu
hzxuzhonghu reviewed Dec 16, 2019
View reviewed changes
pkg/controllers/job/plugins/factory.go Outdated
@@ -40,7 +40,7 @@ var pluginBuilders = map[string]PluginBuilder{}
type PluginBuilder func(pluginsinterface.PluginClientset, []string) pluginsinterface.PluginInterface

// RegisterPluginBuilder register plugin builders
func RegisterPluginBuilder(name string, pc func(pluginsinterface.PluginClientset, []string) pluginsinterface.PluginInterface) {
func RegisterPluginBuilder(name string, PluginBuilder) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you need a param

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2019
@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2019
@TravisBuddy
Copy link

Hey @YesterdayxD,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 94c3f2f0-1fdb-11ea-ba47-7f442aed9c1e

@TravisBuddy
Copy link

Hey @YesterdayxD,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d226c400-1fe1-11ea-ba47-7f442aed9c1e

@TravisBuddy
Copy link

Hey @YesterdayxD,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e9a96d10-1fe8-11ea-ba47-7f442aed9c1e

@volcano-sh-bot volcano-sh-bot merged commit b5e0fa5 into volcano-sh:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YesterdayxD @volcano-sh-bot @hzxuzhonghu @TravisBuddy